|
| Author | Message |
|---|
kzn
(frozen)
| | #1 posted August 18, 2008 at 5:53pm (EST) |
bill, the site doesnt resize images in quote? i've been seeing the first post of the image will be shrunk with the "full" link, but when quoted the image returns to it original size.
 |
bill
  
 
| | #2 posted August 18, 2008 at 6:09pm (EST) |
quoting is a little buggy sometimes; the way it breaks lines can break links... maybe, that's the problem?
Can you give me a link to an example? |
kzn
(frozen)
| | #3 posted August 18, 2008 at 6:10pm (EST) |
http://gametz.com/forum/General/topic/309219.html#...
|
bill
| | #4 posted August 18, 2008 at 6:24pm (EST) |
I think I fixed it... I'll try to look into what caused it too. |
kzn
(frozen)
| | #5 posted August 18, 2008 at 6:24pm (EST) |
|
bill
| | #6 posted August 19, 2008 at 10:57am (EST) |
I made a couple changes... hopefully, this wont break anything.
o when quote-replying, the code makes more of an effort to keep href and img tags together on the same line (to prevent the line break problem)
o the image displayer will try hard to deal properly with getting quote gunk in the middle of a img link.
Let me know if things seem to act funny... |
kzn
(frozen)
| | #7 posted August 19, 2008 at 1:03pm (EST) |
Yeah bill, now they're even bigger! Check the first link and this one
http://gametz.com/forum/General/topic/311792.html#...
|
bill
| | #8 posted August 19, 2008 at 1:06pm (EST) |
which? That topic looks OK to me. |
kzn
(frozen)
| #9 posted August 19, 2008 at 1:12pm (EST)
edited August 19, 2008 at 1:13pm (EST) |
This is how it looks to me.
http://img185.imageshack.us/img185/2701/beforenu5....
http://img185.imageshack.us/img185/9205/afteryc2.j...
I use image zoom mozilla addon for the second pic.
|
Richie
  
| | #10 posted August 19, 2008 at 1:14pm (EST) |
Yeah, I edited out a quoted pic in one topic this morning because it took up probably like 30 page lengths or something!
 |
bill
| | #11 posted August 19, 2008 at 1:21pm (EST) |
Hm... I can't tell what happened. If you know what it looked like before it got edited/fixed, that would help me a lot... or, we could wait for it to happen again... |
kzn
(frozen)
| | #12 posted August 19, 2008 at 1:25pm (EST) |
The first image I posted is what it looks like...all I could see was the corner of that beer picture.
|
bill
| | #13 posted August 19, 2008 at 1:43pm (EST) |
Yeah, I would need to know what the actual test in the post was, so I can reproduce it and fix it.
|
bill
| | #14 posted August 19, 2008 at 1:48pm (EST) |
If it happens again, save what the post contains... |
kzn
(frozen)
| #15 posted August 19, 2008 at 1:51pm (EST)
edited August 19, 2008 at 1:51pm (EST) |
I wish I know what you mean. I still see a giant picture of a beer bottle in that post.
|
kzn
(frozen)
| | #16 posted August 19, 2008 at 1:52pm (EST) |
somethingweird wrote:
> Narclepto99 wrote:
>> 
>>
>> Fudge what you heard.
>
> I had a friend that used to drink those constantly. Then when we
> turned 21 and had enough money to buy decent beer, he quit drinking
> them. But when you're young and only have a few bucks, Steel Reserve
> will get you a long way.
|
kzn
(frozen)
| | #17 posted August 19, 2008 at 1:54pm (EST) |
It's only that post from something weird though, the other quoted posts are fine.
is it because of this line?
 [full]
|
kzn
(frozen)
| | #18 posted August 19, 2008 at 1:56pm (EST) |
this one from Richie of the same image
|
kzn
(frozen)
| | #19 posted August 19, 2008 at 1:57pm (EST) |
do you see a normal picture of the one i quoted above? cause I see it as giant too.
|
bill
| | #20 posted August 19, 2008 at 1:57pm (EST) |
It doesn't show up with IE... I see it does with FireFox... OK, I'll look into this, thanks |
kzn
(frozen)
| #21 posted August 19, 2008 at 1:58pm (EST)
edited August 19, 2008 at 1:59pm (EST) |
kzn wrote:
> somethingweird wrote:
>> Narclepto99 wrote:
> |>>
> |>>
> |>> Fudge what you heard.
>>
>> I had a friend that used to drink those constantly. Then when
> we
>> turned 21 and had enough money to buy decent beer, he quit drinking
>> them. But when you're young and only have a few bucks, Steel Reserve
>> will get you a long way.
>
>
Edit: Yeah, when I edit out the | > in the quote that's breaking the {image} line it looks normal
|
bill
| | #22 posted August 19, 2008 at 2:13pm (EST) |
Right, that's the problem I'm wrestling with. The code that does the quoted reply can break up links (img or href) and it tends to cause a mess.
Part of the issue is that his post was from a few days ago... before I made the fix that would have prevented the break-up. But, I also change the img tags to try better to find a proper height/width despite the line break and > | characters... that caused a problem in this case, though. |
kzn
(frozen)
| | #23 posted August 19, 2008 at 2:18pm (EST) |
So should all the post after the fix be fine? If so I think you should just forget the ones before then, like this particular one, if it's giving you a headache 
You should put quote in a box instead.
|
RiseAgainst540
 
| | #24 posted August 19, 2008 at 2:28pm (EST) |
DAMMMN that's a huge ass pic.
 |
bill
| | #25 posted August 19, 2008 at 2:42pm (EST) |
I just released a fix for it... it seems better... this case, at least.
It's hard to know if a change like this might break other cases, though. So, let me know.
|
sandpaperback
 
| | #26 posted August 19, 2008 at 3:38pm (EST) |
I don't think images should be quoted. You should just make it say [inline image] or something. |
BoB
 
| #27 posted August 19, 2008 at 3:43pm (EST)
edited August 19, 2008 at 3:44pm (EST) |
good call i get sick of the same image 90 times so tardmos can say "lol" after quoting it.
dog, you never played FF8? - Vdub |
kzn
(frozen)
| | #28 posted August 19, 2008 at 3:52pm (EST) |
Like that one time in that one topic?
|
BoB
| | #29 posted August 19, 2008 at 4:00pm (EST) |
 i love you my little yellow brother 
dog, you never played FF8? - Vdub |
bill
| | #30 posted August 19, 2008 at 4:18pm (EST) |
sandpaperback wrote:
> I don't think images should be quoted. You should just make it say
> [inline image] or something.
That's interesting... it may even be possible... or maybe just scale the pic way way down; so people will at least know what they mean... |
Grenadier
| | #31 posted August 19, 2008 at 4:29pm (EST) |
bill wrote:
> sandpaperback wrote:
>> I don't think images should be quoted. You should just
> make it say
>> [inline image] or something.
>
> That's interesting... it may even be possible... or maybe
> just scale the pic way way down; so people will at least
> know what they mean...
Scale it down to a thumbnail, then wrap it in a link that goes back to the original post where the pic came from. 
Click here to join Goozex and get a free game! |
BoB
| | #32 posted August 19, 2008 at 4:31pm (EST) |
yeah a thumb makes sense
dog, you never played FF8? - Vdub |
bill
| #33 posted August 19, 2008 at 5:42pm (EST)
edited August 19, 2008 at 5:43pm (EST) |
OK, I threw together some code that should shrink quoted images to about 1/4th the max size (within 200x200).
For example:
kzn wrote:
>
> [full]
This will only apply to quoted posts made from now on.
I probably broke something, as usual, so let me know if you see more strangeness. |
BoB
| #34 posted August 19, 2008 at 5:43pm (EST)
edited August 19, 2008 at 5:47pm (EST) |
awesome ima go quote stuff now
i did a few quoted re's and it works like a champ
dog, you never played FF8? - Vdub |
bill
| #35 posted August 19, 2008 at 5:58pm (EST)
edited August 19, 2008 at 5:59pm (EST) |
Note that there can be a delay to it... If an image is posted without height width numbers (which is the most common thing), quoting them will no immediately do the scaling. But, there's an hourly script that adds the height width and that will correct all images, including thumb scaling. But, anyway, for up to an hour, an image may remain large and unscaled. In the end, it should all be good, though. And, for images that are over an hour old (most!), no problem. |
sandpaperback
| | #36 posted August 19, 2008 at 6:13pm (EST) |
I love it when a plan comes together.
Nice work Bill! |
John
| | #37 posted August 19, 2008 at 8:33pm (EST) |
Sweet!
- John...
I kissed a girl.
(And I liked it.) |
Rules Help 
- Twitter 
- Facebook 
